fix(expo): make native feature config reversible - #5076
Open
OskarEichler wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
audiobackground mode while preserving unrelated modestruetofalse(or back) while continuing to preserve manual untagged definitionsPreviously most mods ran only for truthy props. A prebuilt project could retain notification controls, PiP, background audio, ads, or caching after the corresponding option was disabled. Generated Podfile values were also mistaken for manual definitions and never updated. At the podspec boundary, a defined
falsestill enabled a feature, while enabling both optional iOS extensions retained only the last Swift flag.Regression coverage
The v6 branch has no test suite (
yarn testreportsno test available), so there is no config-plugin harness to extend. Verified with:falseis inserted and then replaced bytruerbenv exec ruby -c react-native-video.podspecYARN_NODE_LINKER=node-modules yarn prettier --checkon all changed TypeScript filesYARN_NODE_LINKER=node-modules yarn buildYARN_NODE_LINKER=node-modules yarn lintgit diff --checkBreaking changes
Disabled/default-false plugin options now actively remove configuration previously generated by this plugin. A manually defined
falseiOS feature flag now correctly disables that feature. Manual untagged Podfile definitions remain untouched.